fix: Possible perf improvement and logging for team members routing logic #17154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
hariombalhara
commented
Oct 18, 2024
Comment on lines
+31
to
+47
| type SelectFieldWebhookResponse = string | number | string[] | { label: string; id: string | null }; | ||
| type FORM_SUBMITTED_WEBHOOK_RESPONSES = Record< | ||
| string, | ||
| { | ||
| /** | ||
| * Deprecates `value` prop as it now has both the id(that doesn't change) and the label(that can change but is human friendly) | ||
| */ | ||
| response: number | string | string[] | SelectFieldWebhookResponse | SelectFieldWebhookResponse[]; | ||
| /** | ||
| * @deprecated Use `response` instead | ||
| */ | ||
| value: FormResponse[keyof FormResponse]["value"]; | ||
| } | ||
| >; | ||
| type TeamMemberWithAttributeOptionValuePerAttribute = Awaited< | ||
| ReturnType<typeof getTeamMembersWithAttributeOptionValuePerAttribute> | ||
| >[number]; |
There was a problem hiding this comment.
Just moved types above
hariombalhara
force-pushed
the
perf-attribute-logic
branch
from
a107eaa
to
f160bcd
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
hariombalhara
changed the title
dosubot
bot
added
performance
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (10/18/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (10/18/24)1 label was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables Server timings to be able to identify what is slow:
What they represent
Locally I don't see much improvement with a concurrency of 2 though. But the logging would help us in knowing what is the biggest bottle neck
Mandatory Tasks (DO NOT REMOVE)